Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export functions and content providers #125

Merged
merged 28 commits into from
Apr 21, 2021
Merged

Export functions and content providers #125

merged 28 commits into from
Apr 21, 2021
+721 −108

Conversation

SbastianGarzon
Copy link
Collaborator

@SbastianGarzon SbastianGarzon commented Apr 6, 2021 •
edited
Loading

This pull request implements:

TO DO

  • Tests for export function
  • Tests for Zenodo retrieval
  • Update documentation

nuest
nuest requested changes Apr 15, 2021
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - good work. I'd like to see a very little bit of cleaning up, and a handful more tests.

geoextent/__main__.py Outdated Show resolved Hide resolved
geoextent/lib/extent.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
nuest
nuest reviewed Apr 21, 2021
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
nuest
nuest requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, have to be nitpicky - very minor changes needed re. code style.

tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
@o2r-project o2r-project deleted a comment from nuest Apr 21, 2021
@SbastianGarzon
Copy link
Collaborator Author

All checks have passed !
This is no longer WIP

@SbastianGarzon SbastianGarzon changed the title [WIP] Export functions and content providers Export functions and content providers Apr 21, 2021
@nuest
Copy link
Member

nuest commented Apr 21, 2021

Good job, @SbastianGarzon !

@nuest nuest merged commit 5433223 into o2r-project:master Apr 21, 2021
@nuest nuest mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuest nuest nuest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SbastianGarzon @nuest